Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOTINCOM (LTIME44) [C++] #109

Merged
merged 1 commit into from
Sep 10, 2017
Merged

NOTINCOM (LTIME44) [C++] #109

merged 1 commit into from
Sep 10, 2017

Conversation

piyush-pawar-17
Copy link
Contributor

@piyush-pawar-17 piyush-pawar-17 commented Sep 7, 2017

Fixes #107

  • Pull Request Title is of form Problem Code (Contest Code) [Language].
  • This problem already had an entry in this repository.
    • This solution is better than the one already in this repository.
  • This solution is prepared by me and not copied from anywhere else on the web.
  • I have added a copyright comment in my solution.
  • I have updated README.md file (in appropriate order).
  • I have read and followed Code Samples.
  • I understand that pull request will be closed if I failed to update it even once in a week.

int n, m;
cin >> n >> m;
vector<short int> collection(1e+6, 0);
for (int i = 0; i < n + m; i++) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to use ++i instead of i++, as this repo is concerned towards competitve programming. So the solution should be fast and efficient in terms of solution.

Follow this link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make major difference for primitives

Have a look at this

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, resolve conflicts ASAP.

@Monal5031
Copy link
Member

@aashutoshrathi Its better if we let the author of PR do the work of resolving conflicts and updating PR.

@aashutoshrathi
Copy link
Member

No, I think it's okay, if anyone does it, just for speeding up the process.

@Monal5031
Copy link
Member

@aashutoshrathi I understand its good for speeding up the process but this repo was aimed for learning purposes, and resolving conflicts is important part of a PR.

@aashutoshrathi aashutoshrathi merged commit cd3f98c into iiitv:master Sep 10, 2017
@piyush-pawar-17 piyush-pawar-17 deleted the NOTINCOM branch September 10, 2017 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NOTINCOM (LTIME44) [C++]
4 participants