-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIKECS03 (COOK86) [C++] #168
Conversation
Hi! Thanks for PR. |
Mention issue number in the first line of PR Description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Feel free to watch and star for more updates
@aashutoshrathi already done bro. learning to contribute more in open source. Enjoyed it.. :) just one doubt? All pull requests are counted for hactoberfest? I have many more questions solution to put but doing them like this (one for every question) will take a lot of time. any alternative for it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Code in the link mentioned is totally different from the one you have submitted. Please change the code.
@aashutoshrathi Please don't do such carelessness while reviewing.
@Monal5031 it is correct. go through complete history. |
@manish1997 Sorry but I'm not saying anything over the correctness of solution, but its mandatory that the code you submit is not changed logicwise or timewise, though you can change it to look better. |
@Monal5031 you call naming from pre to present different? I wrote linked code during contest in my own way. But while pushing i changed it for better reading ability. I removed my builtin functions which were not used and i keep in my template in general. For more check out github.com/manish1997 |
@Monal5031 ok so i just changed it for making it better. removed code which was not called anywhere. Do u want me to change it? |
@Monal5031 Try to be less careless while reviewing PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my bad, was confused over the function name.
@Monal5031 label is still not approved. |
@manish1997 The PR is merged, don't worry 😉 Still as you asked I changed the label 😄 |
Wait let me automate it |
Fixes #161
Problem Code (Contest Code) [Language]
.