Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIKECS03 (COOK86) [C++] #168

Merged
merged 3 commits into from
Oct 2, 2017
Merged

LIKECS03 (COOK86) [C++] #168

merged 3 commits into from
Oct 2, 2017

Conversation

manish1997
Copy link
Contributor

@manish1997 manish1997 commented Oct 2, 2017

Fixes #161

  • Pull Request Title is of form Problem Code (Contest Code) [Language].
  • This problem already had an entry in this repository.
    • This solution is better than the one already in this repository.
  • This solution is prepared by me and not copied from anywhere else on the web.
  • I have added a copyright comment in my solution.
  • I have updated README.md file (in the appropriate order).
  • I have read and followed Code Samples.
  • I understand that pull request will be closed if I failed to update it even once in a week.

@aashutoshrathi
Copy link
Member

Hi! Thanks for PR.
Make sure you have checked points in PR Template correctly.

@aashutoshrathi
Copy link
Member

Mention issue number in the first line of PR Description

Copy link
Member

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
Feel free to watch and star for more updates

@manish1997
Copy link
Contributor Author

@aashutoshrathi already done bro. learning to contribute more in open source. Enjoyed it.. :) just one doubt? All pull requests are counted for hactoberfest? I have many more questions solution to put but doing them like this (one for every question) will take a lot of time. any alternative for it?

Copy link
Member

@Monal5031 Monal5031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Code in the link mentioned is totally different from the one you have submitted. Please change the code.
@aashutoshrathi Please don't do such carelessness while reviewing.

@manish1997
Copy link
Contributor Author

@Monal5031 it is correct. go through complete history.

@Monal5031
Copy link
Member

@manish1997 Sorry but I'm not saying anything over the correctness of solution, but its mandatory that the code you submit is not changed logicwise or timewise, though you can change it to look better.

@manish1997
Copy link
Contributor Author

@Monal5031 you call naming from pre to present different? I wrote linked code during contest in my own way. But while pushing i changed it for better reading ability. I removed my builtin functions which were not used and i keep in my template in general. For more check out github.com/manish1997

@manish1997
Copy link
Contributor Author

@Monal5031 ok so i just changed it for making it better. removed code which was not called anywhere. Do u want me to change it?

@aashutoshrathi
Copy link
Member

@Monal5031 Try to be less careless while reviewing PRs
https://www.diffchecker.com/i0QRRMeq

Copy link
Member

@Monal5031 Monal5031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my bad, was confused over the function name.

@Monal5031 Monal5031 merged commit 42d284a into iiitv:master Oct 2, 2017
@manish1997
Copy link
Contributor Author

@Monal5031 label is still not approved.

@Monal5031
Copy link
Member

Monal5031 commented Oct 2, 2017

@manish1997 The PR is merged, don't worry 😉 Still as you asked I changed the label 😄

@aashutoshrathi
Copy link
Member

Wait let me automate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LIKECS03 (COOK 86) [C++]
3 participants