Added quicksort C implementation #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashLadha
previously approved these changes
Mar 8, 2017
quicksort/quicksort.c
Outdated
| int main(){ | ||
| int ar_size = 4, i; | ||
| int a[4]; | ||
| a[0] = 2; a[1] = 3; a[2] = 0; a[3] = 4; |
There was a problem hiding this comment.
Maybe simply
int a[4] = {2, 3, 0, 4};
|
@singhpratyush this code looks good. I am closing my review. |
|
There are still some corrections to be done. @aviaryan : Please take a look at all the comments. |
aviaryan
force-pushed
the
add-quicksort-c
branch
from
ecef7cb to
c475d65
Compare
# Conflicts: # README.md
|
@singhpratyush Please review and squash merge this PR. |
singhpratyush
approved these changes
Mar 9, 2017
quicksort/quicksort.c
Outdated
| } | ||
| } | ||
|
|
||
| int main(){ |
There was a problem hiding this comment.
There should be a space after ).
quicksort/quicksort.c
Outdated
| if ((prevind>-1) && (ar[i] < prevmax)){ | ||
| temp = ar[i]; | ||
| ar[i] = prevmax; | ||
| ar[ prevind ] = temp; |
There was a problem hiding this comment.
Please make spaces in index consistent.
quicksort/quicksort.c
Outdated
| #include "stdio.h" | ||
|
|
||
|
|
||
| void quicksort(int ar_size, int * ar) { |
|
Will merge locally because of conflicts |
|
@singhpratyush There are no conflicts. |
|
All set. Thanks. |
rashinanwani
pushed a commit
to rashinanwani/algos
that referenced
this pull request
Jun 24, 2017
# This is the 1st commit message: # This is a combination of 5 commits. # This is the 1st commit message: changes # This is the commit message iiitv#2: changes # This is the commit message iiitv#3: changes # This is the commit message iiitv#4: changes # This is the commit message iiitv#5: changes # This is the commit message iiitv#2: Added Coin Change Problem [JavaScript] (iiitv#317) * Added CoinChangeProblem [JavaScript] * undo changes in other files * Travis fix 1.0 * Travix fix v1.1 * Update comments # This is the commit message iiitv#3: fixed readme conflicts # This is the commit message iiitv#4: conflicts # This is the commit message iiitv#5: changes # This is the commit message iiitv#6: changes # This is the commit message iiitv#7: conflicts # This is the commit message iiitv#8: changes # This is the commit message iiitv#9: changes # This is the commit message iiitv#10: changes # This is the commit message iiitv#11: conflicts # This is the commit message iiitv#12: conflicts # This is the commit message iiitv#13: conflicts # This is the commit message iiitv#14: conflicts # This is the commit message iiitv#15: conflicts # This is the commit message iiitv#16: Added Longest Common Subsequence [Python] (iiitv#353) * Added Longest Common Subsequence [Python] Fixes iiitv#340 * changes * travis issues # This is the commit message iiitv#17: Added Counting Sort [Go] (iiitv#361) * Added Shell Sort [Javascript] * Added Shell Sort [Javascript] * Auto stash before rebase of "origin/master" Fix spaces * Added param comment * Renamed * Fixed temp declaration * Added Counting Sort [Go] * Time complexity corrected * size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2