Fixed median algorithm bug #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for showing interest in contributing to this repository. Please make sure that you have ticked the points mentioned in PR description correctly. Thanks again! |
| return i | ||
| elif aj == med_val: | ||
| return j | ||
| return k |
There was a problem hiding this comment.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: pep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp4__xq2to/quick_sort/quick_sort.py
+++ b/tmp/tmp4__xq2to/quick_sort/quick_sort.py
@@ -14,6 +14,7 @@
elif aj == med_val:
return j
return k
+
def partition(array, l, r):
"""There was a problem hiding this comment.
Ah yes - my apologies. My pep8 vim plugin did not catch this for some reason.... updating the PR now!
j-haj
force-pushed
the
issue436-fix-quicksort
branch
from
48f051e to
b280c26
Compare
|
@singhpratyush I added an extra newline and updated the commit |
Monal5031
approved these changes
Oct 5, 2017
Monal5031
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436
Modified the algorithm slightly to first find the median value, then find the index corresponding to that value. The basic idea is to sum the values, then remove the max and min values, leaving the median as the result.
By submitting this pull request I confirm I've read and complied with the below declarations.
Added {Algorithm/DS name} [{Language}], notUpdate README.mdorAdded new code.