Added Binary Search Tree [Go] #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for showing interest in contributing to this repository. Please make sure that you have ticked the points mentioned in PR description correctly. Thanks again! |
mohitkyadav
requested changes
Oct 12, 2017
|
I've added it to the readme |
mohitkyadav
requested changes
Oct 13, 2017
| if ok { | ||
| fmt.Println("This shouldn't happen, since key should have been deleted") | ||
| } else { | ||
| fmt.Println("12 was not found :)") |
There was a problem hiding this comment.
Why it's "12 was not found". Use a variable if you want to use it more than once. Avoid hardcoding.
| } | ||
|
|
||
| // Delet a key | ||
| bst.Delete(12) |
There was a problem hiding this comment.
Please implement error handling for this function, it falls into a run time error if passed a non existing key.
| // Searching for a key. Should return value and whether key was found or not | ||
| value, ok := bst.Search(12) | ||
| if ok { | ||
| fmt.Printf("Key 12 was found! It's value is %d\n", value) |
aashutoshrathi
approved these changes
Oct 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #527
By submitting this pull request I confirm I've read and complied with the below declarations.
Added {Algorithm/DS name} [{Language}], notUpdate README.mdorAdded new code.