Added Backtracking algorithm (N-Queen Problem) [Go] #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for showing interest in contributing to this repository. Please make sure that you have ticked the points mentioned in PR description correctly. Thanks again! |
mohitkyadav
requested changes
Oct 14, 2017
n_queen_problem/n_queen_problem.go
Outdated
| func main() { | ||
| var n int | ||
| print("Enter the value of 'N' ") | ||
| fmt.Scanf("%d", &n) |
There was a problem hiding this comment.
No need to ask the value of n, take any sample value.
mohitkyadav
requested changes
Oct 14, 2017
n_queen_problem/n_queen_problem.go
Outdated
| return false | ||
| } | ||
|
|
||
| func placeQueen(b *[][]int, n int) bool { |
There was a problem hiding this comment.
I don't know what that exactly means but changed the function name to PlaceQueen and added a comment before it as explanation.
n_queen_problem/n_queen_problem.go
Outdated
| n := 8 // size of chess board (n x n) | ||
|
|
||
| // make board | ||
| b := make([][]int, n) |
There was a problem hiding this comment.
Please use common variable names such as, n => size, b => board.
There was a problem hiding this comment.
Yes that makes more sense. Done.
mohitkyadav
approved these changes
Oct 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #535
By submitting this pull request I confirm I've read and complied with the below declarations.
Added {Algorithm/DS name} [{Language}], notUpdate README.mdorAdded new code.