Added Trie [Go] #551
Merged
Added Trie [Go] #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for showing interest in contributing to this repository. Please make sure that you have ticked the points mentioned in PR description correctly. Thanks again! |
|
Comment on 9676605, file trie/trie.go, line 7. exported const AlphabetSize should have comment or be unexported Origin: GoLintBear, Section: |
mohitkyadav
reviewed
Oct 20, 2017
trie/trie.go
Outdated
| } | ||
|
|
||
| // put returns a pointer to a node (representing a subtrie) | ||
| func put(nnode *node, key []byte, value string, d int) *node { |
There was a problem hiding this comment.
Please rename nnode and d variables to some informative names.
trie/trie.go
Outdated
| // and this array will have the size of the alphabet. | ||
| // Setting to a smaller size (in allowed alphabet) will | ||
| // lower the space needed for the trie | ||
| const AlphabetSize int = 256 // bytesize |
There was a problem hiding this comment.
Please avoid inline comments.
mohitkyadav
approved these changes
Oct 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #546
By submitting this pull request I confirm I've read and complied with the below declarations.
Added {Algorithm/DS name} [{Language}], notUpdate README.mdorAdded new code.