Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Depth First Traversal [python] #570

Merged
merged 4 commits into from
Oct 26, 2017
Merged

Add Depth First Traversal [python] #570

merged 4 commits into from
Oct 26, 2017

Conversation

amineHorseman
Copy link
Contributor

Fixes #558

By submitting this pull request I confirm I've read and complied with the below declarations.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the coding guidelines for this project.
  • My code follows the skeleton code structure.
  • This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

@singhpratyush
Copy link
Member

Hi! Thanks for showing interest in contributing to this repository.

Please make sure that you have ticked the points mentioned in PR description correctly.

Thanks again!

singhpratyush
singhpratyush reviewed Oct 24, 2017
View reviewed changes
depth_first_traversal/DepthFirstTraversal.py Outdated
@@ -0,0 +1,25 @@
def depthFirstTraversal(graph, node, visited):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code. Thanks for that!

Would you like to add the iterative approach too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll add it in the same file

singhpratyush
singhpratyush reviewed Oct 25, 2017
View reviewed changes
depth_first_traversal/DepthFirstTraversal.py Outdated
'F': ['C'],
'G': []}

print "Recusrive:"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use parentheses with print. The code needs to be Python3 compatible too.

singhpratyush
singhpratyush reviewed Oct 25, 2017
View reviewed changes
depth_first_traversal/DepthFirstTraversal.py Outdated
for node in result:
print(node)

print "Iterative:"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need to be fixed too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sorry

@singhpratyush singhpratyush merged commit 0b52cc7 into iiitv:master Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singhpratyush singhpratyush singhpratyush approved these changes

Assignees
No one assigned
Labels
test/PASSING
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Depth First Traversal [Python]
2 participants
@amineHorseman @singhpratyush