Added Counting Sort [C#] #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork
merge origin into forked master
Counting sort c#
|
Hi! Thanks for showing interest in contributing to this repository. Please make sure that you have ticked the points mentioned in PR description correctly. Thanks again! |
aashutoshrathi
requested changes
Nov 28, 2017
counting_sort/CountingSort.cs
Outdated
| /// Space Complexity: O(n + k) | ||
| /// </summary> | ||
| /// <param name="arr">The original unsorted array</param> | ||
| /// <returns>The sorted array</returns> |
There was a problem hiding this comment.
Make it one block comment instead.
counting_sort/CountingSort.cs
Outdated
| sortedArr[frequency[arr[i]] - 1] = arr[i]; | ||
| frequency[arr[i]]--; | ||
| } | ||
|
|
There was a problem hiding this comment.
no need of blank line here
counting_sort/CountingSort.cs
Outdated
| { | ||
| int[] arr = new int[10000]; | ||
| Random rand = new Random(); | ||
| for (int i = 0; i < arr.Length; i++) |
There was a problem hiding this comment.
Check Counting sort in other languages, try not to use Random and hardcode the input values.
algos/counting_sort/counting_sort.c
Line 32 in 63ac50b
Code refactoring based on PR feedback
origin to fork
singhpratyush
approved these changes
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #611
By submitting this pull request I confirm I've read and complied with the below declarations.
Added {Algorithm/DS name} [{Language}], notUpdate README.mdorAdded new code.