-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sync icons from Material to reduce toolbox clutter #1265
base: master
Are you sure you want to change the base?
Conversation
Same can be done for other common plugins like bookmark, drawtools... |
I like the idea of cleaning up the toolbox. This was never merged. Maybe due to the faction biased colour choice? Does anyone think its a good idea to do similar with other things? I could probably take a crack at it. |
It's not faction biased, it's just reusing the visual common sense to report disabled (gray), error (red), or ok (green) sync status. |
Imagine there are 3 plugins with icons. Could we avoid triple including the same stylesheet in the head? |
I suggest not import heavy third-party Google icons, which slows down the IITC start, but to import only the necessary Google Material icons in svg format, as I started here: |
First, if it's exactly the same URL, the cached content will be reused, not triple downloaded. We can mitigate this by assign an id to check if it's already there: if ( $( "#material-icons-stylesheet" ).length == 0 ) {
// add Google Material icons.
$("head").append(
'<link id="material-icons-stylesheet" rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons">'
);
} |
In effort to reduce toolbox cluttering, here a change to use Material Icons font's icons for Sync plugin.
See screenshot: