Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issue, mock tracker on server #5

Merged
merged 9 commits into from
Sep 21, 2022
Merged

Conversation

ijkml
Copy link
Owner

@ijkml ijkml commented Sep 19, 2022

Module improvements #3

mock umami tracker functions on server
- add mock functions on server side with same typings as client-side
- add gentle warning when using mock during development
- log error instead of throwing (throwing crashes the app)
@ijkml ijkml mentioned this pull request Sep 20, 2022
@ijkml ijkml linked an issue Sep 20, 2022 that may be closed by this pull request
src/module.ts Outdated Show resolved Hide resolved
src/runtime/plugin.ts Show resolved Hide resolved
@ijkml
Copy link
Owner Author

ijkml commented Sep 20, 2022

Thank you! Good to go?

@ijkml ijkml merged commit 6bb5db7 into main Sep 21, 2022
@ijkml ijkml deleted the client-only-patch branch September 29, 2022 12:19
ijkml added a commit that referenced this pull request Apr 5, 2023
Fix compatibility issue, mock tracker on server
ijkml added a commit that referenced this pull request Apr 5, 2023
Fix compatibility issue, mock tracker on server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module improvements
2 participants