Use ast to find candidate fstring expressions #183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long due refactoring. At the time flynt was created,
ast
module didn't allow to find both start and end of the expression in the source code, therefore it was needed to have another, more complicated solution. Since python 3.8,ast
allows to find exact start and end of the expression in the source code, and this was already used in string concatenations.This PR moves functionality over to the new mechanism, leaving deletion of legacy code for future PRs.