This repository has been archived by the owner on Jun 13, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow handlers to return anything that impls
: serde::Serialize
. This is backward-compatible with the currentserde_json::Value
return type, but also allows for()
return types or any other serde-compatible type - the main point here is to be able to return anything that is#[derive(Serialize)]
.This is an inefficient implementation, as it uses both
serde_json::value::to_value
andcpython_json::from_value
to convert. However, this two-step conversion was necessary previously if using serde, so in many cases it's no less efficient than before! Directly converting using a function likefn to_object<S: Serialize>(py: Python, s: S) -> Result<PyObject, Error>
would be ideal, but that first needs to be written.