Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequency quantity #30

Closed
iliekturtles opened this issue May 19, 2017 · 4 comments
Closed

Frequency quantity #30

iliekturtles opened this issue May 19, 2017 · 4 comments

Comments

@iliekturtles
Copy link
Owner

Add frequency quantity and associated units.

iliekturtles added a commit that referenced this issue Jun 29, 2017
Additional units still needed. Part of #30.
@Aehmlo
Copy link
Contributor

Aehmlo commented Apr 2, 2018

What more units would you like to see added? I'd be hesitant to include such things as angular frequencies, since it's easy to misuse that, but I'm not sure what other frequency units would be useful.

@iliekturtles
Copy link
Owner Author

Invert some of the time units and add cycles per day/hour/minute/year.

@Aehmlo
Copy link
Contributor

Aehmlo commented Apr 3, 2018

As far as nomenclature goes, would you prefer e.g. per_hour, inverse_hour, or another style? (cycles_per_hour comes to mind, but I'm again leery of that due to the possible 2π multiplier and the non-unit radian, which it seems we might want to keep out of the unit of measure crate.)

@iliekturtles
Copy link
Owner Author

I think cycles_per_hour with an abbreviation of 1/h sounds best. This also seems to be most consistent with SI which used to use "cycles per second" before adopting Hz.

I still need to figure out how to deal with different quantities that have the same dimension (see #3). Frequency and angular frequency fall into this category and ideally the solution will ensure that units for these different quantities fall into different enums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants