Add dynamic viscosity quantity with related units and tests #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crystal-growth
force-pushed
the
add_dynamic_viscosity
branch
from
b5500ee to
22555bc
Compare
|
Rebased to current master, fixing merge conflict in mod.rs. |
iliekturtles
requested changes
Aug 12, 2022
|
I'm not sure about plurals for Poise The newer texts use standard SI units or abbreviations |
crystal-growth
force-pushed
the
add_dynamic_viscosity
branch
from
0803061 to
7e2e775
Compare
iliekturtles
requested changes
Aug 15, 2022
Co-authored-by: Mike Boutin <[email protected]>
crystal-growth
force-pushed
the
add_dynamic_viscosity
branch
from
ef5eb09 to
ae5fb3f
Compare
|
Thank you! |
|
Thanks so much for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic viscosity quantity [Pressure x Time] with derived and imperial units.