Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hydrodynamics-related quantities. #79

Closed
wants to merge 5 commits into from
Closed

Add hydrodynamics-related quantities. #79

wants to merge 5 commits into from

Conversation

Aehmlo
Copy link
Contributor

@Aehmlo Aehmlo commented Apr 21, 2018

This closes #68, #70, #71, and #72.

@Aehmlo Aehmlo changed the title Add hydrodynamics-related properties. Add hydrodynamics-related quantities. Apr 21, 2018
@iliekturtles
Copy link
Owner

Thanks for another huge PR! I didn't get to pressure and density yet.

  • Mass rate
    • Wrap at 100 characters.
    • Add tests for carat_per_second through ton_per_second. I don't think the pound_per_minute/_hour conversion factors have enough precision. Add another generic parameter to the test function to accept the time unit.
    • Add at least kilogram_per_minute/_hour. Consider a few more like gram_per_minute or _day suffixes for got kilograms and pounds. The full prefix x prefix matrix isn't necessary but I'd like to see a few of the more common combinations.

@iliekturtles
Copy link
Owner

  • Pressure
    • Change centimeter_of_mercury_4 to "@centimeter_of_water_4: ...; "cm H₂O (4 °C)", "centimeter of water (4 °C)", "centimeters of water (4 °C)";
    • Add tests for non-SI units where the force unit exists.
  • Density
    • Some of the <sup> tags got messed up with .
    • grain_per_gallon conversion factor should be E-2.
    • Add test for non-SI units where the mass and volume units exist.

@Aehmlo
Copy link
Contributor Author

Aehmlo commented Apr 26, 2018

I've fixed these, and tests for these quantities are now much more robust.

iliekturtles added a commit that referenced this pull request Apr 27, 2018
Add hydrodynamics-related quantities.
@iliekturtles
Copy link
Owner

Resolving conflicts in github didn't work as expected so I manually merged the changes into master. Thanks again for all the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Density quantity
2 participants