This repository has been archived by the owner on Feb 3, 2024. It is now read-only.
Improve Login Experience #3150
Merged
Improve Login Experience #3150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've aligned our configuration with the frontend to remove token refresh and updated the login itself to use the token we pass and not a refreshed version. We still attempt to use the token to get a new token to ensure the passed token is valid and when there are errors in that process they will now display correctly.
stopfstedt
approved these changes
Nov 16, 2022
| this.session.authenticate(authenticator, { jwt: obj.jwt }); | ||
| this.session.authenticate(authenticator, { jwt: this.jwt }); | ||
| } else { | ||
| this.error = await response.text(); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've aligned our configuration with the frontend to remove token refresh and updated the login itself to use the token we pass and not a refreshed version. We still attempt to use the token to get a new token to ensure the passed token is valid and when there are errors in that process they will now display correctly.