This repository has been archived by the owner on Feb 3, 2024. It is now read-only.
check app env and suppress back-to link in the frontend app. #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
suggested changes
Aug 22, 2023
| module('Unit | Controller | events', function (hooks) { | ||
| setupTest(hooks); | ||
|
|
||
| // TODO: Replace this with your real tests. |
There was a problem hiding this comment.
Probably delete the entire test?
There was a problem hiding this comment.
this test stub gets generated by the ember CLI when creating a new controller. it has marginal value, perhaps we should remove all of those controller tests.
config/environment.js
Outdated
| @@ -4,6 +4,7 @@ const API_VERSION = require('./api-version.js'); | |||
|
|
|||
| module.exports = function (environment /*, appConfig */) { | |||
| var ENV = { | |||
| modulePrefix: 'ilios', | |||
There was a problem hiding this comment.
I'm not sure if this is the right place this should go anymore. I dunno for sure though based on EmberCLI/pull/10049 having it here probably pushes it up the tree, I think it should go in tests/dummy/config/environment.js I may be wrong though.
There was a problem hiding this comment.
thanks for catching this. this was leftover from tinkering around with env settings and shouldn't be there. removed. ✔️
this was leftover kruft from tinkering around with this.
jrjohnson
approved these changes
Aug 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another attempt at fixing ilios/ilios#4774
this time, we check the environment for the application "name" (
modulePrefixkey).note: we can't get to it using
getConfigfrom@ember/macros, so i'm using the tried/true approach instead.