This repository was archived by the owner on Feb 3, 2024. It is now read-only.
Replace Our Token Library #3514
Merged
+367
−1,004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd love to keep using it, but we're having trouble keeping it up to date. Doing this work ourselves is reasonable as most of the code can be removed since we don't support many of the options supported by the addon.
We not longer need to get this from a polyfill, all of our targeted browsers have fetch included.
Since ember isn't hooked into the async work here we need to do a little bit of extra magic to ensure tests wait for this promise to resolve before continuing.
NPM wants to match up our dependencies and our peer dependencies, let's allow that.
Some copy paste issues here, plus I've consolidated this now that I better understand what is going on here.
I'm trying to make this as easy to follow as possible, it was doing very strange things with CAS auth and I wasn't able to track down where that was happening, hopefully this will fix it or at least make it easier to find the bug.
|
Testing is done as much as feasible. We'll do more after getting this merged into frontend before releasing. Ready for code review. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd love to keep using
ember-simple-auth-token, but we're having trouble keeping it up todate. Doing this work ourselves is reasonable as most of the code can be
removed since we don't support many of the options supported by the
addon.
Turns out we were getting
ember-fetchfrom this library so I had to do a little magic where we were using fetch as well.Then cleanup on dependencies elsewhere because
npmpicked today to be weird for some reason, or else the removal of this library unlocked some kind of deep other things.This is ready for review / testing / discussion, but not for merge.
Pre-merge test steps: