This repository has been archived by the owner on Feb 3, 2024. It is now read-only.
Remove optimization for saving learner groups #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was designed to only modify, and only return, groupss which were modified which is nice because it limits network requests when modifying groups trees with lots of subgroups. This turns out to be a bad idea however because users may open multiple tabs and modify the group tree in each tab. Any user errors in this process can lead to changes not being reflected back to the API because the data store in the tab they have open does not realize a change to other groups is necessary. I've removed that optimization here. It's less network efficient, however it should result in consistent data being sent to the API.
stopfstedt
approved these changes
Sep 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was designed to only modify, and only return, groupss which were modified which is nice because it limits network requests when modifying groups trees with lots of subgroups. This turns out to be a bad idea however because users may open multiple tabs and modify the group tree in each tab. Any user errors in this process can lead to changes not being reflected back to the API because the data store in the tab they have open does not realize a change to other groups is necessary. I've removed that optimization here. It's less network efficient, however it should result in consistent data being sent to the API.
Refs ilios/ilios#4953