This repository has been archived by the owner on Feb 3, 2024. It is now read-only.
Replace deprecation workflow #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addon has been amazing, but I've failed in my attempt to modernize it and we can duplicate all of it's functionality with our own initializer which unlocks our embroider upgrade and seems like a good tradeoff.
We don't want to inject this code into every application, only when we're developing. I've also decided to throw on new deprecations. This will require making updates to dependabot PRs when a new deprecation is added, but it will also prevent us from stacking up a ton of deprecations and having to track them down.
stopfstedt
approved these changes
Sep 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addon has been amazing, but I've failed in my attempt to modernize
it and we can duplicate all of it's functionality with our own
code which unlocks our embroider upgrade and seems like a good
tradeoff.
I've also decided to throw on new deprecations. This
will require making updates to dependabot PRs when a new deprecation is
added, but it will also prevent us from stacking up a ton of
deprecations and having to track them down.