This repository has been archived by the owner on Feb 3, 2024. It is now read-only.
Load icons from sprite file #3642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the fontawesome javascript process we can load our icons out of the sprite file and reference them in components. This requires a larger initial download, however the browser will cache that data. I think we can play some pre-loading games like we do for fonts to push the sprite files along with the initial page request to improve this even more. This allows us to drop all of the fontawesome addon and move away from our team needing to work to maintain that addon ourselves and should unblock our move to pnpm.
|
the original FaIcon component could take a this leads to some (minor) changes that are not intentional. before
after
the affected components are: |
stopfstedt
suggested changes
Jan 5, 2024
The ellipses fontawesome icon was using the transform property which requires javascript computations to align correctly. This is the only place we're using the transform so I manually re-created the effect in a new component.
jrjohnson
added
run percy tests
stopfstedt
approved these changes
Jan 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the fontawesome javascript process we can load our icons out of the sprite file and reference them in components. This requires a larger initial download, however the browser will cache that data. I think we can play some
pre-loading games like we do for fonts to push the sprite files along with the initial page request to improve this even more.
This allows us to drop all of the fontawesome addon and move away from our team needing to work to maintain that addon ourselves and should unblock our move to pnpm.