This repository was archived by the owner on Feb 3, 2024. It is now read-only.
Consolidate font size information #3643
Merged
+32
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
font-constants
branch
from
a2b43e6 to
f67b2a8
Compare
jrjohnson
added
run percy tests
Having this in the mixin meant it was included hundreds of times. CSS is fast so this wasn't a huge deal performance wise, but it makes looking at the dev panel annoying and made me feel like a bad developer. Fixed!
jrjohnson
force-pushed
the
font-constants
branch
from
f67b2a8 to
4ad1c06
Compare
stopfstedt
approved these changes
Jan 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having this in the mixin meant it was included hundreds of times. CSS is fast so this wasn't a huge deal performance wise, but it makes looking at the dev panel annoying and made me feel like a bad developer. Fixed!