Skip to content

Commit

Permalink
rm loading state check that was causing start/end level task chaining…
Browse files Browse the repository at this point in the history
… problems.

turns out this is both unnecessary and causing new trouble.
the issue here is that the start/end academic level getter chain runs as soon as a new value is set on the given sequence block, causing the in-place editor component from being unloaded instantly, thus aborting the save task chain. madness!
  • Loading branch information
stopfstedt committed Dec 17, 2024
1 parent f379ce7 commit 8dee589
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@
</div>
<div class="block starting-academic-level" data-test-starting-academic-level>
<label for="academic-level-{{templateId}}">{{t "general.startLevel"}}:</label>
{{#if (and @canUpdate this.startingAndEndingAcademicLevelsLoaded)}}
{{#if @canUpdate}}
<EditableField
@value={{this.startingAcademicLevel.name}}
@save={{perform this.changeStartingAcademicLevel}}
Expand All @@ -386,7 +386,7 @@
</div>
<div class="block ending-academic-level" data-test-ending-academic-level>
<label for="academic-level-{{templateId}}">{{t "general.endLevel"}}:</label>
{{#if (and @canUpdate this.startingAndEndingAcademicLevelsLoaded)}}
{{#if @canUpdate}}
<EditableField
@value={{this.endingAcademicLevel.name}}
@save={{perform this.changeEndingAcademicLevel}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,6 @@ export default class CurriculumInventorySequenceBlockOverviewComponent extends C
return this.endingAcademicLevelData.isResolved ? this.endingAcademicLevelData.value : null;
}

get startingAndEndingAcademicLevelsLoaded() {
return this.startingAcademicLevelData.isResolved && this.endingAcademicLevelData.isResolved;
}

@cached
get courseData() {
return new TrackedAsyncData(this.args.sequenceBlock.course);
Expand Down

0 comments on commit 8dee589

Please sign in to comment.