fixed a11y issue with how multiple parent objs were being combined

ilios · Nov 26, 2024 · a4285d6 · a4285d6
1 parent aa94006
commit a4285d6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/packages/ilios-common/addon/components/course/objective-list-item-parents.hbs b/packages/ilios-common/addon/components/course/objective-list-item-parents.hbs
@@ -31,7 +31,6 @@
         @onExpandAll={{@onExpandAllFadeText}}
         as |displayText expand collapse updateTextDims shouldFade expanded|
       >
-        <ul>
         {{#if @editable}}
           <span data-test-parent>
             <button type="button" class="link-button" {{on "click" @manage}} data-test-manage>
@@ -58,7 +57,6 @@
             </div>
           </span>
         {{/if}}
-        </ul>
         {{#if shouldFade}}
           <div
             class="fade-text-control"

diff --git a/packages/ilios-common/addon/components/fade-text.js b/packages/ilios-common/addon/components/fade-text.js
@@ -15,7 +15,10 @@ export default class FadeTextComponent extends Component {
     }
     if (typeOf(this.args.text) !== 'string') {
       if (typeOf(this.args.text) === 'array') {
-        return this.args.text.map((elem) => `<li>${elem}</li>`).join('');
+        let text = '<ul>';
+        text += this.args.text.map((elem) => `<li>${elem}</li>`).join('');
+        text += '</ul>';
+        return text;
       }
       return this.args.text.toString();
     }

diff --git a/packages/ilios-common/addon/components/session/objective-list-item-parents.hbs b/packages/ilios-common/addon/components/session/objective-list-item-parents.hbs
@@ -31,7 +31,6 @@
         @onExpandAll={{@onExpandAllFadeText}}
         as |displayText expand collapse updateTextDims shouldFade expanded|
       >
-        <ul>
         {{#if @editable}}
           <span data-test-parent>
             <button type="button" class="link-button" {{on "click" @manage}} data-test-manage>
@@ -58,7 +57,6 @@
             </div>
           </span>
         {{/if}}
-        </ul>
         {{#if shouldFade}}
           <div
             class="fade-text-control"