Skip to content

Commit

Permalink
Drop Support for Safari 15.x
Browse files Browse the repository at this point in the history
Changing our support to only cover the last two major safari versions on
OSX as our stats show that this will cover our users and we can move
more quickly to some modern Javascript and improve performance for
everyone else by not including dead code.

We wern't able to drop the crypto polyfill because ios Safari doesn't
support it in "insecure" contexts at this version. Hoping that will be
fixed in the future.
  • Loading branch information
jrjohnson committed Aug 22, 2024
1 parent 42d0438 commit e1e5c68
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion packages/frontend/config/targets.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ if (isCI || isProduction) {
browsers.push('last 3 edge versions');
browsers.push('firefox esr'); //sometimes points to the last 2 ESR releases when they overlap
browsers.push('last 2 iOS major versions');
browsers.push('last 3 safari major versions');
browsers.push('last 2 safari major versions');
browsers.push('last 3 ChromeAndroid versions');
browsers.push('last 3 Chrome versions');
}
Expand Down
4 changes: 2 additions & 2 deletions packages/frontend/testem.browserstack.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ const BrowserStackLaunchers = {
'--os',
'OS X',
'--osv',
'Monterey',
'Ventura',
'--b',
'safari',
'--bv',
'latest', // Will always be 15.x on Monterey
'latest', // Will always be 16.x on Ventura
...defaultArgs,
],
protocol: 'browser',
Expand Down
2 changes: 1 addition & 1 deletion packages/ilios-common/addon/utils/load-polyfills.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export async function loadPolyfills() {
//we need CRYPTO.randomUUID until we drop support for Safari 15.x
//we need CRYPTO.randomUUID until we drop support for iOS Safari 16.x as that version doesn't provide it in insecure (aka test) contexts
installUUIDPolyfill();
}

Expand Down
4 changes: 2 additions & 2 deletions packages/lti-course-manager/testem.browserstack.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ const BrowserStackLaunchers = {
'--os',
'OS X',
'--osv',
'Monterey',
'Ventura',
'--b',
'safari',
'--bv',
'latest', // Will always be 15.x on Monterey
'latest', // Will always be 16.x on Ventura
...defaultArgs,
],
protocol: 'browser',
Expand Down
4 changes: 2 additions & 2 deletions packages/lti-dashboard/testem.browserstack.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ const BrowserStackLaunchers = {
'--os',
'OS X',
'--osv',
'Monterey',
'Ventura',
'--b',
'safari',
'--bv',
'latest', // Will always be 15.x on Monterey
'latest', // Will always be 16.x on Ventura
...defaultArgs,
],
protocol: 'browser',
Expand Down
2 changes: 1 addition & 1 deletion packages/test-app/config/targets.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ if (isCI || isProduction) {
browsers.push('last 3 edge versions');
browsers.push('firefox esr'); //sometimes points to the last 2 ESR releases when they overlap
browsers.push('last 2 iOS major versions');
browsers.push('last 3 safari major versions');
browsers.push('last 2 safari major versions');
browsers.push('last 3 ChromeAndroid versions');
browsers.push('last 3 Chrome versions');
}
Expand Down
4 changes: 2 additions & 2 deletions packages/test-app/testem.browserstack.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ const BrowserStackLaunchers = {
'--os',
'OS X',
'--osv',
'Monterey',
'Ventura',
'--b',
'safari',
'--bv',
'latest', // Will always be 15.x on Monterey
'latest', // Will always be 16.x on Ventura
...defaultArgs,
],
protocol: 'browser',
Expand Down

0 comments on commit e1e5c68

Please sign in to comment.