removed file-upload deprecation #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrjohnson need help verifying this code works. It let me upload a simple text file, but it returns server error when I click on the link to the uploaded file, which I assume it's for direct download. |
|
I think problems testing are related to ilios/ilios#1190 |
|
This will require #1230 to be merged so it can be tested. |
|
👍 works! @homu r+ |
|
📌 Commit e7bda7c has been approved by |
homu
added a commit
that referenced
this pull request
Dec 9, 2015
removed file-upload deprecation Deprecation Warning: - Observing the `files` attr is deprecated, use `filesDidChange` instead.
|
☀️ Test successful - status |
stopfstedt
pushed a commit
to stopfstedt/frontend
that referenced
this pull request
Mar 6, 2024
Update Transitive Dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation Warning:
filesattr is deprecated, usefilesDidChangeinstead.