Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding new file learning material #1231

Merged
merged 1 commit into from
Dec 9, 2015
Merged

Conversation

jrjohnson
Copy link
Member

We were not sending enough information to attach the file to the record.
This sends the fileHash with new learning materials

Fixes #1230

@jrjohnson
Copy link
Member Author

Should be testable against demo.

@saschaben
Copy link
Member

actually, not testable against demo, as demo doesn't allow the upload of files. needs to be tested on stage for validation.

@saschaben saschaben assigned jrjohnson and unassigned saschaben Dec 9, 2015
@jrjohnson
Copy link
Member Author

@saschaben I just validated as working against the demo API. Seems to allow the creation of new files. Is that something we need to fix / prevent?

@jrjohnson jrjohnson assigned saschaben and unassigned jrjohnson Dec 9, 2015
@jrjohnson
Copy link
Member Author

This should be tested with a small file or else wait a few seconds after uploading before clicking save. Separate ticket #1232 for handling the delay correctly.

@saschaben
Copy link
Member

Looks good now. still throwing a 500 error when attempting to download from the calendar event detail page though (but not from the course management page).

@jrjohnson
Copy link
Member Author

👍 from @saschaben. Can you create another issue for the detail download?

@jrjohnson jrjohnson assigned thecoolestguy and unassigned saschaben Dec 9, 2015
@saschaben
Copy link
Member

can't recreate. nm

@thecoolestguy
Copy link
Member

@homu r+

@homu
Copy link
Contributor

homu commented Dec 9, 2015

📌 Commit 226e246 has been approved by thecoolestguy

@homu
Copy link
Contributor

homu commented Dec 9, 2015

⚡ Test exempted - status

@homu homu merged commit 226e246 into ilios:master Dec 9, 2015
homu added a commit that referenced this pull request Dec 9, 2015
Fix adding new file learning material

We were not sending enough information to attach the file to the record.
This sends the fileHash with new learning materials

Fixes #1230
@jrjohnson jrjohnson deleted the 1230-newfilelm branch December 10, 2015 07:18
stopfstedt pushed a commit to stopfstedt/frontend that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants