-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix adding new file learning material #1231
Conversation
Should be testable against demo. |
actually, not testable against demo, as demo doesn't allow the upload of files. needs to be tested on stage for validation. |
@saschaben I just validated as working against the demo API. Seems to allow the creation of new files. Is that something we need to fix / prevent? |
This should be tested with a small file or else wait a few seconds after uploading before clicking save. Separate ticket #1232 for handling the delay correctly. |
Looks good now. still throwing a 500 error when attempting to download from the calendar event detail page though (but not from the course management page). |
👍 from @saschaben. Can you create another issue for the detail download? |
can't recreate. nm |
@homu r+ |
📌 Commit 226e246 has been approved by |
⚡ Test exempted - status |
Fix adding new file learning material
We were not sending enough information to attach the file to the record.
This sends the fileHash with new learning materials
Fixes #1230
Update Transitive Dependencies
We were not sending enough information to attach the file to the record.
This sends the fileHash with new learning materials
Fixes #1230