Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken publish and schedule functionality #1288

Merged
merged 2 commits into from
Jan 1, 2016

Conversation

jrjohnson
Copy link
Member

The publish event was never getting saved so nothing was getting
published.

The publish event was never getting saved so nothing was getting
published.
@saschaben
Copy link
Member

This looks to be solid so far from the UX side; testing proxied against demo means not being able to verify the data in the publish_event table vs. the course/session tables, but functionally this appears to be on it.

This ensures that it passes next year as well
@saschaben
Copy link
Member

👍

@saschaben
Copy link
Member

@jrjohnson if this is ready now with the test modification for merge, let me know. (You still have it tagged as 'in progress')

@jrjohnson
Copy link
Member Author

Waffle does that tagging. It's ready as far as I am concerned.

saschaben added a commit that referenced this pull request Jan 1, 2016
Fix broken publish and schedule functionality
@saschaben saschaben merged commit 124375a into ilios:master Jan 1, 2016
@jrjohnson jrjohnson deleted the 1287-publishborked branch January 1, 2016 19:07
stopfstedt pushed a commit to stopfstedt/frontend that referenced this pull request Mar 6, 2024
…use-db-1.0.30001481

Bump caniuse-db from 1.0.30001480 to 1.0.30001481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants