Update ember-simple-auth version #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a big change in a couple of ways: There are deprecations aplenty and a big API change that requires the session to be an injected service. Changed all the authenticated routes to use the new correct mixing Changed the application route to override sessionInvalidated instead of the sessionInvalidationSucceeded action. Also had to write a custom ajax service to ensure that authentication headers get sent with requests. Had to modify the application adapter to send auth data with ember-data requests.
New ember-simple-auth requires a different setup, this also future proofs us for user fixture changes.
Use UTC so tests don’t fail in the afternoon
If we don’t do this the console fills up with messages about it.
If we don’t do this then some tests fail
Workaround to avoid correctly setting up the dependency injection for the test.
This allows us to use the ajax service so errors written to the API will be authenticated. Also removes one of our deprecation notices.
This wasn't recoputing correctly so shibboleth initial requests were not firing
|
This PR is currently deployed to https://ilios-stage.ucsf.edu/ so the shibboleth part can be tested there. |
stopfstedt
changed the title
|
login works. logout works, although using the browser's back button from the SSO logout page will log you back. i also noticed that the application throws errors after logging out, before redirecting to the SSO logout page.
|
|
Back button logout seems to be an existing issue in production. Must be hanging on to a cookie. I will investigate. |
|
I created a new issues #1304 for the back button problem. Will investigate separately. |
stopfstedt
added a commit
that referenced
this pull request
Jan 7, 2016
Update ember-simple-auth version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of ember-simple-auth 1.0 several changes are required. This is a critical update on our path to Ember 2.0 as well as allowing for a simplification and paves the way for new features of the currentUser service.
Outstanding issues after testing: