fixes regression in calendar filtering due to blanked out scheduled events. #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would probably make sense to refactor into a computed property that just returned events with info. But this is a good solution for now. When tests pass I will merge. |
|
Need rebase |
…ciated data points.
saschaben
added a commit
that referenced
this pull request
Jan 11, 2016
…ering fixes regression in calendar filtering due to blanked out scheduled events.
stopfstedt
added a commit
to stopfstedt/frontend
that referenced
this pull request
Mar 6, 2024
…r/string-3.1.0 Bump @ember/string from 3.0.1 to 3.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schedules events don't carry information about their origin, hence attempting to load their owning session/course data fails and breaks the filtered calendar.
omitting them during filtering fixes this regression.