Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user profile screen #1719

Merged
merged 5 commits into from
May 26, 2016
Merged

Add user profile screen #1719

merged 5 commits into from
May 26, 2016

Conversation

jrjohnson
Copy link
Member

Users can no view their own profile with a link in the user menu. I also split up the user and translations menu and made the whole thing responsive.

Fixes #980

jrjohnson added 2 commits May 22, 2016 16:55
Allows the user to view their own profile information for school
membership, cohorts, and learner groups.
Header links now in two menus.  One for translations and one for user
tasks.
jrjohnson added 2 commits May 23, 2016 23:38
Little bit of cleanup needed from the introduction of my-profile
component.
@jrjohnson
Copy link
Member Author

@saschaben I took some liberties restructuring the header adding a separate menu for translations and user actions. Take a look and see what you think. They change slightly in response to the size of the window as well.

Also see if we are including the right information on the my-profile page that is linked to from the user navigation in the header.

@saschaben
Copy link
Member

👍 I think the header is great. the data appears to be correct, and for a first shot includes a decent baseline. We can always add further info if it seems appropriate.

the "student" label (class="is-student") should be a little more prominent though. right now it fades into the background above the roles box. Please bump it up in font size a couple points and bold it.

@jrjohnson
Copy link
Member Author

@saschaben ready for another review.

@saschaben
Copy link
Member

👍 💯

@saschaben saschaben assigned jrjohnson and unassigned saschaben May 24, 2016
@jrjohnson jrjohnson assigned stopfstedt and unassigned jrjohnson May 24, 2016
@@ -1,17 +1,14 @@
import Ember from 'ember';

const { Component, computed, inject } = Ember;
const { oneWay, equal } = computed;
const { service } = inject;

export default Component.extend({
session: service(),
currentUser: Ember.inject.service(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with currentUser: service(),.

@stopfstedt
Copy link
Member

LGTM

@stopfstedt stopfstedt merged commit 139c393 into ilios:master May 26, 2016
@jrjohnson jrjohnson deleted the 980-userprofile branch May 26, 2016 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants