-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user profile screen #1719
Add user profile screen #1719
Conversation
Allows the user to view their own profile information for school membership, cohorts, and learner groups.
Header links now in two menus. One for translations and one for user tasks.
Little bit of cleanup needed from the introduction of my-profile component.
@saschaben I took some liberties restructuring the header adding a separate menu for translations and user actions. Take a look and see what you think. They change slightly in response to the size of the window as well. Also see if we are including the right information on the my-profile page that is linked to from the user navigation in the header. |
👍 I think the header is great. the data appears to be correct, and for a first shot includes a decent baseline. We can always add further info if it seems appropriate. the "student" label (class="is-student") should be a little more prominent though. right now it fades into the background above the roles box. Please bump it up in font size a couple points and bold it. |
@saschaben ready for another review. |
👍 💯 |
@@ -1,17 +1,14 @@ | |||
import Ember from 'ember'; | |||
|
|||
const { Component, computed, inject } = Ember; | |||
const { oneWay, equal } = computed; | |||
const { service } = inject; | |||
|
|||
export default Component.extend({ | |||
session: service(), | |||
currentUser: Ember.inject.service(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace with currentUser: service(),
.
LGTM |
Users can no view their own profile with a link in the user menu. I also split up the user and translations menu and made the whole thing responsive.
Fixes #980