Course style overhaul #1775
Merged
Course style overhaul #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saschaben ready for another review. |
|
LGTM. Now we just need to tackle the objectives animation & spinner on parent selection load.... |
Use DDAU and more clear variables
Should get rid of more inherited classes and styles
Course header now responsive and separately styleable
Now responsive and better ordered
Session details gets its own set of colors for these items. This should probably be declared in each component, but this seems to work.
These are styled differently from the course detail elements
Courses and session detail components now have new classes and structure, the tests needed to be tweaked to match.
Needed to separate styling of learning material manager when we have the search box display and when we are in edit more with no search box
Needed to match new HTMl structure of session-overview
Just using .actions was hitting the controls on the objective title
Otherwise it impacts controls when editing existing materials.
jrjohnson
force-pushed
the
1771-coursestyle
branch
from
9776d53 to
727238a
Compare
|
@stopfstedt ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Course details and session details are now in most responsive blocks and styled using mixins so those area that need to be customized are easy to get to.
Fixes #1771
Fixes #1739