removed max-date constraint on date picker for rollover start date #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,8 +51,7 @@ | |||
| {{pikaday-input | |||
| size=10 | |||
| value=startDate | |||
| maxDate=maxDate | |||
| minDate=minDate | |||
| minDate=startDate | |||
There was a problem hiding this comment.
I think this should be course.startDate
Otherwise it will change as the startDate is changed so if you pick July 5th you wont be able to go back to July 4th.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changing the academic year selection will result in a max date recalculation. however, the date picker does not pick up on that, it will continue to operate on the originally set min/max date ranges.
the same applies to the min date of that range, the recalculated date does not get applied in the date picker. the base-line requirement is that the rollover date cannot come before the course's original start date, which can be enforced. updated the date picker component to take the course start date as min date instead.