Validate competency title #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
1845-comtitle
branch
2 times, most recently
from
1880ab0 to
f6a8ae1
Compare
|
click tested. LGTM. tests are failing, looking into it. |
| this.$('input').trigger('change'); | ||
| this.$('button').click(); | ||
|
|
||
| assert.ok(false); |
There was a problem hiding this comment.
Ha! Yea, Turns out my new Test Reminder Development paradigm works!
Allows us to validate the domain title to ensure it is legal.
By using the same component we get the same set of validations for each of these.
This makes it easier to validate competency titles when editing. Also don't immediately save the competency title, only save it when the manager is closed.
This test fails in lots of cases where the browser chooses not to place focus on the put. For example if any other test has failed then focus is on the failing test and can't be re-directed. Or if testing in two browsers this test will fail because one browser is is not focuses by the OS.
|
click tested again, and reviewed code. looks all good to me. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before attempting to save a new competency or edit an existing one validate that the title exists and is less than 200 characters.
Fixes #1845