Add ember exam #1996
Merged
Add ember exam #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add bower to cache Split into 4 processes Use multiple variables to split tests into acceptance groups Move non-acceptance tests to the front so we will fail faster when they are broken
These were never that effective and ember-exam provides a better test splitting strategy.
This was necessary for ember-cli 2.7 which moves the test loaded from bower to NPM.
Test is no longer needed
This is necessary because tests create and destroy this object very quickly.
Test was only checking CPs and was flakey.
100ms isn't long enough, every other test here uses a full second.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember exam makes it possible to split tests and run them in parallel. This has two advantages:
It turns out there were some problems here that had to be worked out:
1 - testgroups just got in the way, they are removed, the bulk of the file changes are just removing those.
2 - We had some tests that would sporadically fail when run in isolation this way. I fixed those and that is the rest of the file changes. The next step is probably to add randomization to try and identify these ordering issues.
I attempted to keep commits separate so hopefully it is easy to follow the changes I had to make to get this working.