Move to Fontawesome 5 #3566
Merged
Move to Fontawesome 5 #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
delete icon in instructor group name labels is fekakdeh: |
|
Additional notes: |
|
Addressed the missing nav icon and the spacing issue. The missing LM icons will need to be fixed in common if we come closer to a release. |
jrjohnson
force-pushed
the
fort-fa5
branch
8 times, most recently
from
d46652c to
ce1e750
Compare
Replace FA4 icons with their FA5 equivalents Use official addon in place of ember-font-awesome addon Default to the pro regular style, except for the navigation which is in solid. Default to the solid style icon After group review this is our best icon choice and we can default to it. Fixup tests with bad references to icons Our move to FA5 invalidated these selectors Remove local ember-fontawesome dependency
ember-simple-auth-token v4 simplified the API and we needed to make some changes to our custom authenticator to handle them.
dartajax
approved these changes
Aug 24, 2018
jrjohnson
pushed a commit
to jrjohnson/frontend
that referenced
this pull request
Feb 7, 2024
Pin old node version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be a work in progress, needed a place to test and to run tests.
Fixes #1864