Test in all supported browsers #6832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
i4273-browserstack
branch
from
6c65d35 to
bc98339
Compare
|
3/18 Files got Bigger 🚨: Details
15/18 Files stayed the same size 🤷: Details
Created by ember-asset-size-action |
jrjohnson
force-pushed
the
i4273-browserstack
branch
5 times, most recently
from
e2ec4c1 to
35a37bd
Compare
jrjohnson
force-pushed
the
i4273-browserstack
branch
from
35a37bd to
f9ffa60
Compare
jrjohnson
force-pushed
the
i4273-browserstack
branch
3 times, most recently
from
667d58f to
13a575c
Compare
jrjohnson
force-pushed
the
i4273-browserstack
branch
2 times, most recently
from
e83b814 to
e86ab8d
Compare
jrjohnson
force-pushed
the
i4273-browserstack
branch
from
e86ab8d to
67f8cba
Compare
jrjohnson
force-pushed
the
i4273-browserstack
branch
from
67f8cba to
9898a2e
Compare
jrjohnson
force-pushed
the
i4273-browserstack
branch
2 times, most recently
from
5860891 to
839be21
Compare
Using the browserstack API along with installing and running firefox ESR versions to test all of our supported browser versions so we can ensure everything works for all of our users.
We needed to specify the major versions in our targets in order to get the safari browsers we actually intended to support. While ember goes back even further we can safely cap our support at the last 3 major versions to cover the ios and OSX releases with security updates.
In order to cover some mobile devices and get the versions we really thought we were already supporting.
These are the changes that have worked in common.
This ensures we don't get stuck in a weird time, safari especially seems to need this.
We have this in our other chart tests, we need to wait for loading all the data and rendering the chart otherwise this test is flaky.
I also consolidated all of these common arguments into a single place to make it easier to edit them in the future.
With the release of Safari 16 we're no longer supporting Safari 13 and can drop it from our tests. Firefox ESR 91 is now EOL and 102 is the only supported ESR version so we can update our tests to stop checking ESR 91. Edge 104 is the currently active edge version.
We hide these columns from small screens to these are not visible on some test devices, however the HTML is present and we can check for that.
These are not real dates in our API and we mess with them in the serializer which can make them flaky across timezones. Instead treat them as date strings.
Updated to match our current supported browsers.
This is required for browserstack as the ember-cli-browserstack addon doesn't quite parse strings correctly. Fix is merged upstream, but unreleased.
jrjohnson
force-pushed
the
i4273-browserstack
branch
from
839be21 to
075483c
Compare
These are not real dates and using a JS Date makes testing across timezones and browsers very difficult. Sending a string is what our API does, so it works well this way.
jrjohnson
force-pushed
the
i4273-browserstack
branch
from
075483c to
f15c7e1
Compare
We were missing some features of these when they display on a mobile device with a smaller screen.
Otherwise we check the entire page which breaks in smaller screens.
stopfstedt
requested changes
Jan 24, 2024
The existing method doesn't work in Safari in contexts that aren't secure. This includes our browser tests. Should we generate tokens in insecure contexts? I'm not sure, but we have always allowed Ilios to run without SSL, it's not a great idea, but we haven't, so far, been in the business of requiring a secure connection. This generation of an ICS token doesn't, in my mind, provide less security. In an insecure context we'd already be passing this data around anyway. The method itself is secure enough that the resulting token should not be guessable, which is all that is required.
This one breaks randomly, it may be a delay in updating the property on the model so I'm gonna try this and see if adding a bit of delay helps.
jrjohnson
force-pushed
the
i4273-browserstack
branch
from
616b1a4 to
92d360d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the browserstack API along with installing and running firefox ESR
versions to test all of our supported browser versions so we can ensure
everything works for all of our users.
Fixes ilios/ilios#4273
So.....
Requires ilios/common#3033