Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable embroider #7267

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Enable embroider #7267

merged 1 commit into from
Jan 25, 2024

Conversation

jrjohnson
Copy link
Member

@jrjohnson jrjohnson commented Jun 28, 2023

Tests are passing and everything appears to be working, let's turn this on and see how it works.

Issues:

@jrjohnson
Copy link
Member Author

I'm seeing a speedup of 1-4 seconds loading time on 4G simulated network and several megabytes less javascript. Even compressed it's 500K less JS shipped. Yay. @dartajax please test this netlify build for any weirdness. Initial load and speed for students should be significantly improved.

I'd like to test on a variety of devices and with several users so let's not merge this yet, but it's ready for that testing in my opinion.

@jrjohnson jrjohnson requested a review from dartajax June 28, 2023 06:11
@dartajax
Copy link
Member

This is not a review but merely a comment. This PR acts weirdly if the session gets stale like when you go eat lunch and come back, which is what I did. I even raised a sentry upon rage-clicking after eating my lunch. @jrjohnson may want us to continue testing on this.

@dartajax
Copy link
Member

Except for my previous comment, my testing has gone fine on this PR - added DO NOT MERGE just so we don't accidentally force this through - more review / testing is still necessary.

@jrjohnson jrjohnson force-pushed the enable-embroider branch 2 times, most recently from 9538130 to 52a7b80 Compare September 29, 2023 22:26
@jrjohnson
Copy link
Member Author

@dartajax ready for another review, still in the do not merge status, but if it checks out we may be ready to merge this week.

@dartajax
Copy link
Member

image

image

@dartajax
Copy link
Member

I was testing against demo with my screen shots above. It turns out I should have been testing against our current netlify build. The current netlify build has the same issue as the screen shots above; therefore, this issue is not related to this PR but is another issue we will need to fix once these changes have been pushed up to demo, which they have not been pushed to ... yet.

Copy link
Member

@dartajax dartajax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far so good - I plan on testing this more still but it seems fine to me

Tests are passing and everything appears to be working, let's turn this on and see how it works.
@jrjohnson jrjohnson marked this pull request as ready for review January 25, 2024 16:55
@jrjohnson
Copy link
Member Author

@dartajax when you feel like this has been well tested it's ready to merge! 🎉

@dartajax dartajax merged commit b6801d9 into ilios:master Jan 25, 2024
16 checks passed
@jrjohnson jrjohnson deleted the enable-embroider branch January 25, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants