-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable embroider #7267
Enable embroider #7267
Conversation
I'm seeing a speedup of 1-4 seconds loading time on 4G simulated network and several megabytes less javascript. Even compressed it's 500K less JS shipped. Yay. @dartajax please test this netlify build for any weirdness. Initial load and speed for students should be significantly improved. I'd like to test on a variety of devices and with several users so let's not merge this yet, but it's ready for that testing in my opinion. |
This is not a review but merely a comment. This PR acts weirdly if the session gets stale like when you go eat lunch and come back, which is what I did. I even raised a sentry upon rage-clicking after eating my lunch. @jrjohnson may want us to continue testing on this. |
Except for my previous comment, my testing has gone fine on this PR - added |
9538130
to
52a7b80
Compare
52a7b80
to
64ff6af
Compare
64ff6af
to
276c7b8
Compare
@dartajax ready for another review, still in the do not merge status, but if it checks out we may be ready to merge this week. |
I was testing against demo with my screen shots above. It turns out I should have been testing against our current netlify build. The current netlify build has the same issue as the screen shots above; therefore, this issue is not related to this PR but is another issue we will need to fix once these changes have been pushed up to demo, which they have not been pushed to ... yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so far so good - I plan on testing this more still but it seems fine to me
Tests are passing and everything appears to be working, let's turn this on and see how it works.
276c7b8
to
0cafbae
Compare
@dartajax when you feel like this has been well tested it's ready to merge! 🎉 |
Tests are passing and everything appears to be working, let's turn this on and see how it works.
Issues: