Add Search for course, session, and lm reports #7419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of picking them from a list find courses using the query api and display them. This removes the academic year picker because that can be part of the search term if it's needed to filter.
The academic year picker, which was used in course and session reports isn't part of the UI anymore.
Instead of picking from a drop down users search for a session using the query api and then choose it from the list.
Instead of choosing from a dropdown, which was too big to even load.
While the network request resolves there should be some indication that search is running.
Initial feedback on the listed results was very negative, it caused confusion about what selecting an item did and how that related to the report being created. Instead I've gone with the type of autocomplete pickers we use elsewhere in the app.
See previous commit, meets user requirements.
Better user experience see previous commit
Mostly users will be looking for the most recent course so we can move it to the top of the list and make it easier to find.
jrjohnson
force-pushed
the
4358-subject-search
branch
from
8c38b66 to
45a8f04
Compare
stopfstedt
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4358 by replacing the dropdown lists on these reports with a search box.