Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new service import from Ember #7546

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Use new service import from Ember #7546

merged 1 commit into from
Dec 27, 2023

Conversation

jrjohnson
Copy link
Member

This is better, let's us it. Plus the old way is going to deprecated at some point.

@jrjohnson
Use new service import from Ember
2c5bdd6 
This is better, let's us it. Plus the old way is going to deprecated at
some point.
@jrjohnson jrjohnson marked this pull request as ready for review December 27, 2023 20:04
@jrjohnson jrjohnson requested a review from stopfstedt December 27, 2023 20:05
stopfstedt
stopfstedt approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stopfstedt stopfstedt merged commit 358e1f9 into ilios:master Dec 27, 2023
12 checks passed
@jrjohnson jrjohnson deleted the replace-service-import branch December 27, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stopfstedt stopfstedt stopfstedt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrjohnson @stopfstedt