Catch missing model 404s #7560
Merged
Catch missing model 404s #7560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if this broke or was never working but we're not displaying a nice error when a model is missing. This doesn't happen that often for us, but when something is deleted we need to do better than or standard error message because refreshing the page will just continue to be broken. Instead we now display our "Rats!" message with a link back to the dashboard.
If we split this route then ember's default error substate system doesn't work anymore.
jrjohnson
force-pushed
the
5127-deleted-report
branch
from
5cde3d4 to
1d2bfe0
Compare
stopfstedt
requested changes
Jan 31, 2024
|
hmm, seems to be working fine on netlify. i'm having another go at it locally. |
|
i figured it out - forgot that we have to provide the backend URL on startup as env variable now since dotenv support is gone. *headdesk all is well, this checks out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this broke or was never working but we're not displaying a nice error when a model is missing. This doesn't happen that often for us, but when something is deleted we need to do better than or standard error message because refreshing the page will just continue to be broken. Instead we now display our "Rats!" message with a link back to the dashboard.
Fixes ilios/ilios#5127