Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate frontend into monorepo #7593

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

jrjohnson
Copy link
Member

For now the only repo within this monorepo is the frontend itself, but later we'll be moving everything else in as well. For now get it working alone.

@jrjohnson jrjohnson marked this pull request as ready for review February 2, 2024 01:46
@jrjohnson jrjohnson requested a review from stopfstedt February 2, 2024 01:46
@jrjohnson
Copy link
Member Author

Netlify issues will fix after merging and Percy failures are due to this being the first time Percy has been working in a while.

For now the only repo within this monorepo is the frontend itself, but
later we'll be moving everything else in as well. For now get it working
alone.
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i'm holding this back for the time being due to some routing issues coming out of common.

@stopfstedt
Copy link
Member

unblocked from merging again after further discussion with @jrjohnson. we'll address the mentioned issues as follow-up.

@stopfstedt stopfstedt merged commit 415c1fd into ilios:master Feb 2, 2024
15 of 21 checks passed
@jrjohnson jrjohnson deleted the monorepo branch February 2, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants