Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch off embroider again #7595

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

jrjohnson
Copy link
Member

@jrjohnson jrjohnson commented Feb 2, 2024

We're having some issues with route splitting on sub course routes like print and publication_check. Will need to fix these and then re-enable embroider for our builds.

Refs ilios/ilios#5213

We're having some issues with route splitting on sub course routes like
print and publication_check. Will need to fix these and then re-enable
embroider for our builds.
@stopfstedt stopfstedt marked this pull request as ready for review February 2, 2024 19:32
@stopfstedt stopfstedt self-requested a review February 2, 2024 19:32
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404 route tests are currently failing with embroider, we'll fix this afterwards.

@stopfstedt stopfstedt merged commit e17363d into ilios:master Feb 2, 2024
14 of 19 checks passed
@jrjohnson jrjohnson deleted the disable-embroider-again branch February 6, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants