update ember-concurrency task implementations #7645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint was coming at us with a "n/no-missing-require" warning. apparently, it is unable to correctly find this dependency, which is getting exported out ilios-common and not directly declared in frontend. so we have to make an exception here.
…omponents. almost missed those!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yieldsyntax to fat-arrow,async/awaitequivalentin templates, replaceperformhelper with calls to theperform()method directly on the givens Taskson second thought - pass on the
performhelper replacement for now.from the v4.0.0 release notes:
looking at how pervasive our use of the
performhelper throughout common/frontend is, this seems like a pretty big lift without much to gain from at this point.suggesting we wait until that helper gets deprecated in future versions (having proper deprecation output will make it easier to find and replace anyway).