replaces Moment with Luxon in ilios-common utils, decorators, and services #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mild touch-up on the test coverage since the test fixtures for start/end-date were in the incorrect representation before.
stopfstedt
force-pushed
the
replace_moment_with_luxon_utils_decorators_and_services
branch
from
bf38b62 to
8e9425b
Compare
this one has been superseded by EventsBase::getSlugForSchoolEvent() and EventsBase::getSlugForUserEvent().
jrjohnson
approved these changes
Feb 22, 2024
| * @param {Object} event | ||
| * @return {String} | ||
| */ | ||
| getSlugForEvent(event) { |
There was a problem hiding this comment.
I'm guessing this was unused? Good catch - also yay monorepo!
stopfstedt
deleted the
replace_moment_with_luxon_utils_decorators_and_services
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
components and controllers are next (new PR).
companion PR to #7637
refs ilios/ilios#5193