replaces Moment with Luxon in controllers and components in ilios-common - part 1 #7654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
replace_moment_with_luxon_components_controllers_ilios-common
branch
2 times, most recently
from
cb67947 to
459bdee
Compare
minor display change - Luxon prints meridiem as AM and PM (vs Moment, which prints am and pm).
stopfstedt
force-pushed
the
replace_moment_with_luxon_components_controllers_ilios-common
branch
from
459bdee to
904ca71
Compare
stopfstedt
changed the title
- corrects format for dates in test fixtures. - adds missing endDate (mandatory datapoint!) to test fixtures.
stopfstedt
force-pushed
the
replace_moment_with_luxon_components_controllers_ilios-common
branch
from
dc29827 to
bfcaadf
Compare
jumping through hoops no more.
jrjohnson
reviewed
Feb 26, 2024
packages/ilios-common/addon/components/sessions-grid-loading.hbs
Outdated
Show resolved
Hide resolved
apparently, there's currently no way to do this on the fly in a template-only component. at least not without pulling in additional helpers.
jrjohnson
approved these changes
Feb 26, 2024
stopfstedt
deleted the
replace_moment_with_luxon_components_controllers_ilios-common
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ilios/ilios#5193