replaces Moment with Luxon in components in ilios-common - part 2 #7666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
more_moment_with_luxon_replacement
branch
from
c5592ef to
de3c4d5
Compare
Luxon formats localized dates slightly different than Moment - day and month are unpadded numbers in Luxon.
stopfstedt
force-pushed
the
more_moment_with_luxon_replacement
branch
from
a22fd68 to
8e9d89e
Compare
had to convert the datetime test vectors to proper ISO format, since that's what is expected as input.
stopfstedt
force-pushed
the
more_moment_with_luxon_replacement
branch
2 times, most recently
from
c0b5304 to
60357d7
Compare
jrjohnson
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ilios/ilios#5193
contains a minor change in date formatting in the "Session Overview" component - the "last updated" date now displays without padding on day and month info on the given date-time.
Luxon localizes this date differently from Moment, for reasons.
The alternative would be to force a specific format, independent of localization, which surmounts to a loss of functionality.