Build and test all apps with embroider #7685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
embroidery-goodness
branch
from
39d4975 to
9f5f394
Compare
Added CI jobs to build and test and the infrastructure to do this and then cleaned up the relationship with ember-data in all the apps by moving it to dependencies of ilios-common and removing it from each app. This lets embroider handle making it available correctly.
jrjohnson
force-pushed
the
embroidery-goodness
branch
from
9f5f394 to
9843d7d
Compare
Even when there are failures we want to see the results of all of these tests.
This is a leftover from ember a while ago, it doesn't seem to be necessary and it was breaking embroider.
This is the recommended configuration for the best dependency structure, however it doesn't work for us today. I'm leaving it in with the options we want commented out to, hopefully, give us a target to push towards.
Something is up with the latest ember-data release so let's pin here for now.
Without this the babel transform doesn't get resolved in an embroider build.
stopfstedt
reviewed
Mar 6, 2024
There was a problem hiding this comment.
great idea. i appreciate the extra context in the commit message that comes with this as well.
stopfstedt
reviewed
Mar 6, 2024
| @@ -25,10 +25,7 @@ module.exports = function (defaults) { | |||
|
|
|||
| hinting: isTestBuild, | |||
| babel: { | |||
| plugins: [ | |||
| // eslint-disable-next-line | |||
There was a problem hiding this comment.
interesting. so eslint was onto something here after all.
|
|
this step was part of the previous pipeline. i removed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CI jobs to build and test and the infrastructure to do this and then cleaned up the relationship with ember-data in all the apps by moving it to dependencies of ilios-common and removing it from each app. This lets embroider handle making it available correctly.