Swap out moment for Luxon #7702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
luxon-myprofile
branch
2 times, most recently
from
95b615e to
dce1ab8
Compare
stopfstedt
requested changes
Mar 11, 2024
packages/frontend/app/components/curriculum-inventory/new-sequence-block.hbs
Outdated
Show resolved
Hide resolved
packages/frontend/app/components/curriculum-inventory/new-sequence-block.hbs
Outdated
Show resolved
Hide resolved
Luxon returns an object from diffing that can be formatted and sending a double format 'mm' instead of 'm' will automatically pad the result so we can drop the pad work as well.
I also dropped the constructor because we can set date inline and it gets traspiled to the same thing.
We don't need to type force into an integer anymore because that is what DateTime returns for these values.
This internationalizes the output as well. It changes the format slightly (for en it's m/d/y) but I don't see any reason to make this more complicated.
Luxon starts the week on Monday and Ends it on Sunday, however we've been relying on Moment to start it on Sunday so these dates need a small adjustment.
jrjohnson
force-pushed
the
luxon-myprofile
branch
from
8045e90 to
0ea87e3
Compare
stopfstedt
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps up all the components in frontend where we were importing and using moment.